Plot rendering fix when PV disconnects#2189
Merged
georgweiss merged 1 commit intomasterfrom Mar 24, 2022
Merged
Conversation
kasemir
approved these changes
Mar 23, 2022
Collaborator
Collaborator
Author
|
One would assume that Stripchart and Databrowser uses the same plot engine... |
Collaborator
|
Yes. Your original screenshot suggests that the order of samples is somehow getting disturbed. The time stamps must be sorted. The 'fix' on the plotting side just added a new bug. |
Collaborator
Author
|
OK, will take a look. |
1 task
Collaborator
Author
|
Since I cannot reproduce the issue (and neither can the user reporting on it), I have reverted this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



In the Stripchart widget using trace type "step", a horizontal line is painted when the associated PV disconnects. Once it connects the available values will be rendered, but the horizontal line in most cases remains, see screen shot.
This defect is not seen when using trace type "line".
This PR is an attempt to fix the issue so that the behavior for "step" is the same as for "line".